Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 142693006: Add d8 to the chromium_builder_asan target. (Closed)

Created:
6 years, 10 months ago by Martin Barbella
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add d8 to the chromium_builder_asan target. BUG= R=machenbach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249433

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Martin Barbella
Could you take a look at this when you get a chance? We'd like to ...
6 years, 10 months ago (2014-02-04 18:19:06 UTC) #1
Michael Achenbach
LGTM if it has been tested.
6 years, 10 months ago (2014-02-04 19:28:37 UTC) #2
Martin Barbella
The CQ bit was checked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-04 19:29:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mbarbella@chromium.org/142693006/1
6 years, 10 months ago (2014-02-04 19:41:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 23:51:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 23:51:39 UTC) #6
Martin Barbella
The CQ bit was checked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-04 23:57:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mbarbella@chromium.org/142693006/160001
6 years, 10 months ago (2014-02-05 00:13:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mbarbella@chromium.org/142693006/160001
6 years, 10 months ago (2014-02-05 01:46:53 UTC) #9
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-05 19:49:51 UTC) #10
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-05 19:53:19 UTC) #11
Martin Barbella
The CQ bit was unchecked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-05 22:39:48 UTC) #12
Martin Barbella
The CQ bit was checked by mbarbella@chromium.org
6 years, 10 months ago (2014-02-05 22:40:04 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 09:39:44 UTC) #14
commit-bot: I haz the power
List of reviewers changed. phajdan.jr@chromium.org did a drive-by without LGTM'ing!
6 years, 10 months ago (2014-02-06 09:39:44 UTC) #15
Michael Achenbach
I suggest dcommit...
6 years, 10 months ago (2014-02-06 11:26:23 UTC) #16
Martin Barbella
Committed patchset #2 manually as r249433 (presubmit successful).
6 years, 10 months ago (2014-02-06 17:51:47 UTC) #17
Martin Barbella
6 years, 10 months ago (2014-02-06 19:44:13 UTC) #18
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/156863002/ by mbarbella@chromium.org.

The reason for reverting is: This may be causing issues with runhooks. Reverting
to be safe until I have time to investigate..

Powered by Google App Engine
This is Rietveld 408576698