third_party/WebKit/Source/core/html/PluginDocument.cpp - Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/PluginDocument.cpp

Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/npapi/webplugin_impl.cc ('K') | « third_party/WebKit/ManualTests/NPN_Invoke/test.html ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/PluginDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/PluginDocument.cpp b/third_party/WebKit/Source/core/html/PluginDocument.cpp

index dc40f1c589e0c2ed4ec680d099a92f69a9229c59..b10bfbf81946b64efe8a9084a4be079174e91fb4 100644

--- a/third_party/WebKit/Source/core/html/PluginDocument.cpp

+++ b/third_party/WebKit/Source/core/html/PluginDocument.cpp

@@ -135,14 +135,7 @@ void PluginDocumentParser::appendBytes(const char* data, size_t length)

void PluginDocumentParser::finish()

{

- if (PluginView* view = pluginView()) {

- const ResourceError& error = document()->loader()->mainDocumentError();

- if (error.isNull())

- view->didFinishLoading();

- else

- view->didFailLoading(error);

- m_embedElement = nullptr;

- }

+ m_embedElement = nullptr;

RawDataDocumentParser::finish();

}