content/renderer/pepper/pepper_webplugin_impl.cc - Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_webplugin_impl.cc

Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/npapi/webplugin_impl.cc ('K') | « content/renderer/pepper/pepper_webplugin_impl.h ('k') | content/renderer/render_frame_impl.h » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_webplugin_impl.cc

diff --git a/content/renderer/pepper/pepper_webplugin_impl.cc b/content/renderer/pepper/pepper_webplugin_impl.cc

index 2773194caf80bc914b443aab3b3c90a5d3ab8880..6d25999fce16cf8965f5f5dfd52ab3c4bddb3d3c 100644

--- a/content/renderer/pepper/pepper_webplugin_impl.cc

+++ b/content/renderer/pepper/pepper_webplugin_impl.cc

@@ -251,14 +251,6 @@ void PepperWebPluginImpl::didFailLoading(const blink::WebURLError& error) {

document_loader->didFail(NULL, error);

}

-void PepperWebPluginImpl::didFinishLoadingFrameRequest(const blink::WebURL& url,

- void* notify_data) {}

-void PepperWebPluginImpl::didFailLoadingFrameRequest(

- const blink::WebURL& url,

- void* notify_data,

- const blink::WebURLError& error) {}

bool PepperWebPluginImpl::hasSelection() const {

return !selectionAsText().isEmpty();

}