Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: content/renderer/npapi/webplugin_impl.h

Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/npapi/webplugin_impl.h
diff --git a/content/renderer/npapi/webplugin_impl.h b/content/renderer/npapi/webplugin_impl.h
index 75bc0ff4975feebb6371577db0482f764351b015..4fad9f49fe410f5c42a276ee563614e4c4733c76 100644
--- a/content/renderer/npapi/webplugin_impl.h
+++ b/content/renderer/npapi/webplugin_impl.h
@@ -85,15 +85,10 @@ class WebPluginImpl : public WebPlugin,
bool acceptsInputEvents() override;
bool handleInputEvent(const blink::WebInputEvent& event,
blink::WebCursorInfo& cursor_info) override;
- void didReceiveResponse(const blink::WebURLResponse& response) override;
- void didReceiveData(const char* data, int data_length) override;
- void didFinishLoading() override;
- void didFailLoading(const blink::WebURLError& error) override;
- void didFinishLoadingFrameRequest(const blink::WebURL& url,
- void* notify_data) override;
- void didFailLoadingFrameRequest(const blink::WebURL& url,
- void* notify_data,
- const blink::WebURLError& error) override;
+ void didReceiveResponse(const blink::WebURLResponse& response) override {}
+ void didReceiveData(const char* data, int data_length) override {}
+ void didFinishLoading() override {}
+ void didFailLoading(const blink::WebURLError& error) override {}
bool isPlaceholder() override;
// WebPlugin implementation:
@@ -111,18 +106,7 @@ class WebPluginImpl : public WebPlugin,
const std::string& cookie) override;
std::string GetCookies(const GURL& url,
const GURL& first_party_for_cookies) override;
- void HandleURLRequest(const char* url,
- const char* method,
- const char* target,
- const char* buf,
- unsigned int len,
- int notify_id,
- bool popups_allowed,
- bool notify_redirects) override;
void CancelDocumentLoad() override;
- void InitiateHTTPRangeRequest(const char* url,
- const char* range_info,
- int pending_request_id) override;
void DidStartLoading() override;
void DidStopLoading() override;
bool IsOffTheRecord() override;
@@ -174,26 +158,12 @@ class WebPluginImpl : public WebPlugin,
const char* target,
const char* buf,
unsigned int len,
- int notify_id,
ReferrerValue referrer_flag);
// Returns the next avaiable resource id. Returns 0 if the operation fails.
// It may fail if the page has already been closed.
unsigned long GetNextResourceId();
- // Initiates HTTP GET/POST requests.
- // Returns true on success.
- bool InitiateHTTPRequest(unsigned long resource_id,
- WebPluginResourceClient* client,
- const GURL& url,
- const char* method,
- const char* buf,
- int len,
- const char* range_info,
- ReferrerValue referrer_flag,
- bool notify_redirects,
- bool check_mixed_scripting);
-
gfx::Rect GetWindowClipRect(const gfx::Rect& rect);
// Sets the actual Widget for the plugin.
@@ -238,24 +208,10 @@ class WebPluginImpl : public WebPlugin,
bool HandleHttpMultipartResponse(const blink::WebURLResponse& response,
WebPluginResourceClient* client);
- void HandleURLRequestInternal(const char* url,
- const char* method,
- const char* target,
- const char* buf,
- unsigned int len,
- int notify_id,
- bool popups_allowed,
- ReferrerValue referrer_flag,
- bool notify_redirects,
- bool check_mixed_scripting);
-
// Tears down the existing plugin instance and creates a new plugin instance
// to handle the response identified by the loader parameter.
bool ReinitializePluginForResponse(blink::WebURLLoader* loader);
- // Delayed task for downloading the plugin source URL.
- void OnDownloadPluginSrcUrl();
-
struct ClientInfo;
// Helper functions

Powered by Google App Engine
This is Rietveld 408576698