Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
index 60ab35cf439ce584894150ffa595f198ca372518..79bdb99c629a88a3b8ebbc9ed3bab80662178664 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
@@ -487,23 +487,12 @@ WebString WebPluginContainerImpl::executeScriptURL(const WebURL& url, bool popup
return toCoreString(v8::Local<v8::String>::Cast(result));
}
-void WebPluginContainerImpl::loadFrameRequest(const WebURLRequest& request, const WebString& target, bool notifyNeeded, void* notifyData)
+void WebPluginContainerImpl::loadFrameRequest(const WebURLRequest& request, const WebString& target)
{
LocalFrame* frame = m_element->document().frame();
if (!frame || !frame->loader().documentLoader())
return; // FIXME: send a notification in this case?
- if (notifyNeeded) {
- // FIXME: This is a bit of hack to allow us to observe completion of
- // our frame request. It would be better to evolve FrameLoader to
- // support a completion callback instead.
- OwnPtrWillBeRawPtr<WebPluginLoadObserver> observer = WebPluginLoadObserver::create(this, request.url(), notifyData);
-#if !ENABLE(OILPAN)
- m_pluginLoadObservers.append(observer.get());
-#endif
- WebDataSourceImpl::setNextPluginLoadObserver(observer.release());
- }
-
FrameLoadRequest frameRequest(frame->document(), request.toResourceRequest(), target);
frame->loader().load(frameRequest);
}
@@ -680,16 +669,6 @@ bool WebPluginContainerImpl::wantsWheelEvents()
return m_wantsWheelEvents;
}
-#if !ENABLE(OILPAN)
-void WebPluginContainerImpl::willDestroyPluginLoadObserver(WebPluginLoadObserver* observer)
-{
- size_t pos = m_pluginLoadObservers.find(observer);
- if (pos == kNotFound)
- return;
- m_pluginLoadObservers.remove(pos);
-}
-#endif
-
// Private methods -------------------------------------------------------------
WebPluginContainerImpl::WebPluginContainerImpl(HTMLPlugInElement* element, WebPlugin* webPlugin)
@@ -725,11 +704,6 @@ void WebPluginContainerImpl::dispose()
if (m_element && m_touchEventRequestType != TouchEventRequestTypeNone && m_element->document().frameHost())
m_element->document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*m_element, EventHandlerRegistry::TouchEvent);
-#if !ENABLE(OILPAN)
- for (const auto& observer : m_pluginLoadObservers)
- observer->clearPluginContainer();
-#endif
-
if (m_webPlugin) {
RELEASE_ASSERT(!m_webPlugin->container() || m_webPlugin->container() == this);
m_webPlugin->destroy();
@@ -741,9 +715,6 @@ void WebPluginContainerImpl::dispose()
m_webLayer = nullptr;
}
-#if !ENABLE(OILPAN)
- m_pluginLoadObservers.clear();
-#endif
m_element = nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698