Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/child/npapi/plugin_stream.h

Issue 1426923007: Remove PluginLoadObserver and related logic, it was only used for NPAPI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/npapi/plugin_stream.h
diff --git a/content/child/npapi/plugin_stream.h b/content/child/npapi/plugin_stream.h
index 644e16c681b3bcec40bca00a97a40309cfdf12da..ec3cf1e3601f25d7a09e92b42c703b3bc551f6da 100644
--- a/content/child/npapi/plugin_stream.h
+++ b/content/child/npapi/plugin_stream.h
@@ -22,12 +22,9 @@ class WebPluginResourceClient;
// of a stream for NPAPI notifications and stream position.
class PluginStream : public base::RefCounted<PluginStream> {
dcheng 2015/11/18 18:38:18 And probably this thing too. KILL IT ALL.
Nate Chapin 2015/11/18 23:28:50 Done.
public:
- // Create a new PluginStream object. If needNotify is true, then the
- // plugin will be notified when the stream has been fully sent.
+ // Create a new PluginStream object.
PluginStream(PluginInstance* instance,
- const char* url,
- bool need_notify,
- void* notify_data);
+ const char* url);
// Opens the stream to the Plugin.
// If the mime-type is not specified, we'll try to find one based on the
@@ -48,9 +45,6 @@ class PluginStream : public base::RefCounted<PluginStream> {
// Write the result as a file.
void WriteAsFile();
- // Notify the plugin that a stream is complete.
- void Notify(NPReason reason);
-
// Close the stream.
virtual bool Close(NPReason reason);
@@ -68,11 +62,6 @@ class PluginStream : public base::RefCounted<PluginStream> {
void set_seekable(bool seekable) { seekable_stream_ = seekable; }
- // getters for reading the notification related attributes on the stream.
- bool notify_needed() const { return notify_needed_; }
-
- void* notify_data() const { return notify_data_; }
-
protected:
friend class base::RefCounted<PluginStream>;
@@ -124,8 +113,6 @@ class PluginStream : public base::RefCounted<PluginStream> {
NPStream stream_;
std::string headers_;
scoped_refptr<PluginInstance> instance_;
- bool notify_needed_;
- void* notify_data_;
bool close_on_write_data_;
uint16 requested_plugin_mode_;
bool opened_;

Powered by Google App Engine
This is Rietveld 408576698