Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14269004: Add LoginState class to src/chromeos/login (redux) (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, kkania, Aaron Boodman, rginda+watch_chromium.org, robertshield, oshima+watch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add LoginState class to src/chromeos/login (redux) This is the same as https://chromiumcodereview.appspot.com/13495003 rebased. Hopefully the unit tests are more robust now and will not be broken by the added tests changing test order this time. BUG=226495 TBR=xiyuan@chromium.org,nkostylev@chromium.org,bartfab@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194986

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -88 lines) Patch
M ash/system/user/login_status.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 6 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/wimax_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 2 chunks +4 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 3 chunks +30 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/auth_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A chromeos/login/login_state.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chromeos/login/login_state.cc View 1 chunk +105 lines, -0 lines 0 comments Download
A chromeos/login/login_state_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
7 years, 8 months ago (2013-04-18 16:34:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/14269004/1
7 years, 8 months ago (2013-04-18 16:35:20 UTC) #2
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 17:59:27 UTC) #3
stevenjb
7 years, 8 months ago (2013-04-18 19:41:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r194986 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698