Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: cc/trees/single_thread_proxy.cc

Issue 14269002: cc: Clarify text for single thread + impl-painting CHECK (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/single_thread_proxy.h" 5 #include "cc/trees/single_thread_proxy.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "cc/base/thread.h" 9 #include "cc/base/thread.h"
10 #include "cc/output/context_provider.h" 10 #include "cc/output/context_provider.h"
(...skipping 17 matching lines...) Expand all
28 output_surface_lost_(false), 28 output_surface_lost_(false),
29 created_offscreen_context_provider_(false), 29 created_offscreen_context_provider_(false),
30 renderer_initialized_(false), 30 renderer_initialized_(false),
31 next_frame_is_newly_committed_frame_(false), 31 next_frame_is_newly_committed_frame_(false),
32 inside_draw_(false) { 32 inside_draw_(false) {
33 TRACE_EVENT0("cc", "SingleThreadProxy::SingleThreadProxy"); 33 TRACE_EVENT0("cc", "SingleThreadProxy::SingleThreadProxy");
34 DCHECK(Proxy::IsMainThread()); 34 DCHECK(Proxy::IsMainThread());
35 DCHECK(layer_tree_host); 35 DCHECK(layer_tree_host);
36 36
37 // Impl-side painting not supported without threaded compositing. 37 // Impl-side painting not supported without threaded compositing.
38 CHECK(!layer_tree_host->settings().impl_side_painting); 38 CHECK(!layer_tree_host->settings().impl_side_painting)
39 << "Threaded compositing must be enabled to use impl-side painting.";
39 } 40 }
40 41
41 void SingleThreadProxy::Start() { 42 void SingleThreadProxy::Start() {
42 DebugScopedSetImplThread impl(this); 43 DebugScopedSetImplThread impl(this);
43 layer_tree_host_impl_ = layer_tree_host_->CreateLayerTreeHostImpl(this); 44 layer_tree_host_impl_ = layer_tree_host_->CreateLayerTreeHostImpl(this);
44 } 45 }
45 46
46 SingleThreadProxy::~SingleThreadProxy() { 47 SingleThreadProxy::~SingleThreadProxy() {
47 TRACE_EVENT0("cc", "SingleThreadProxy::~SingleThreadProxy"); 48 TRACE_EVENT0("cc", "SingleThreadProxy::~SingleThreadProxy");
48 DCHECK(Proxy::IsMainThread()); 49 DCHECK(Proxy::IsMainThread());
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 469
469 bool SingleThreadProxy::CommitPendingForTesting() { return false; } 470 bool SingleThreadProxy::CommitPendingForTesting() { return false; }
470 471
471 skia::RefPtr<SkPicture> SingleThreadProxy::CapturePicture() { 472 skia::RefPtr<SkPicture> SingleThreadProxy::CapturePicture() {
472 // Impl-side painting only. 473 // Impl-side painting only.
473 NOTREACHED(); 474 NOTREACHED();
474 return skia::RefPtr<SkPicture>(); 475 return skia::RefPtr<SkPicture>();
475 } 476 }
476 477
477 } // namespace cc 478 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698