Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 1426893002: [turbofan] Optimize JSConvertReceiver if we know something about the receiver. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize JSConvertReceiver if we know something about the receiver. Typed lowering can lower JSConvertReceiver either based on the operator hints or the (statically) known receiver type. R=jarin@chromium.org BUG=chromium:548557, v8:4493, v8:4470 LOG=n Committed: https://crrev.com/1d0b7bd28a87f340dafc12155ea4904f3e4f853c Cr-Commit-Position: refs/heads/master@{#31618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/js-operator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-28 08:18:22 UTC) #1
Benedikt Meurer
Hey Jaro, This is the initial optimization for JSConvertReceiver. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-10-28 08:20:22 UTC) #2
Jarin
lgtm. (unit test?)
5 years, 1 month ago (2015-10-28 08:56:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426893002/1
5 years, 1 month ago (2015-10-28 09:02:16 UTC) #6
Benedikt Meurer
On 2015/10/28 08:56:47, Jarin wrote: > lgtm. (unit test?) As discussed offline: We will only ...
5 years, 1 month ago (2015-10-28 09:03:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 09:03:46 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 09:04:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d0b7bd28a87f340dafc12155ea4904f3e4f853c
Cr-Commit-Position: refs/heads/master@{#31618}

Powered by Google App Engine
This is Rietveld 408576698