Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426843004: Remove the task tracking stuff in the bindings. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the task tracking stuff in the bindings. This basically reverts 56a09bd92b33edc7b81a9c52ce35744cf33ff444. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/58c6834d70398a0020a12d5d13e93fdd0d4c0ba2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -461 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D mojo/common/task_tracker.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/common/task_tracker.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D mojo/common/task_tracker_unittest.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M mojo/environment/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/environment/default_task_tracker.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/environment/default_task_tracker.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M mojo/environment/environment.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/public/cpp/environment/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/environment/environment.h View 2 chunks +1 line, -5 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_task_tracker.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/cpp/environment/lib/default_task_tracker.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 3 chunks +4 lines, -17 lines 0 comments Download
M mojo/public/cpp/environment/lib/logging_only_environment.cc View 2 chunks +1 line, -7 lines 0 comments Download
D mojo/public/cpp/environment/lib/scoped_task_tracking.h View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/public/cpp/environment/lib/scoped_task_tracking.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/public/cpp/environment/task_tracker.h View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-10-27 21:34:02 UTC) #1
jamesr
lgtm
5 years, 1 month ago (2015-10-27 21:34:58 UTC) #2
viettrungluu
5 years, 1 month ago (2015-10-27 21:45:42 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
58c6834d70398a0020a12d5d13e93fdd0d4c0ba2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698