Support VariationsRestrictParameter in VariationsService for Chrome OS

chrome/browser/metrics/variations/variations_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/strings/string_split.h"
 #include "chrome/browser/metrics/proto/study.pb.h"
 #include "chrome/browser/metrics/variations/resource_request_allowed_notifier_test_util.h"
 #include "chrome/browser/metrics/variations/variations_service.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
+#endif
+
 namespace chrome_variations {
 
 namespace {
 
 // A test class used to validate expected functionality in VariationsService.
 class TestVariationsService : public VariationsService {
  public:
   TestVariationsService(TestRequestAllowedNotifier* test_notifier,
                         PrefService* local_state)
       : VariationsService(test_notifier, local_state),
@@ skipping 339 matching lines @@
 
 TEST(VariationsServiceTest, VariationsURLIsValid) {
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
   const std::string default_variations_url =
       VariationsService::GetDefaultVariationsServerURLForTesting();
 
   EXPECT_EQ(default_variations_url,
             VariationsService::GetVariationsServerURL(&prefs).spec());
 
+#if defined(OS_CHROMEOS)
+  chromeos::StubCrosSettingsProvider stub_settings_provider;

[Alexei Svitkine (slow), 2013/04/17 21:24:36]

I think it would be cleaner to do this in a separate test case.

You can make a custom testing::Test subclass for that test that handles the
lifetime of the StubCrosSettingsProvider.

[Mathieu, 2013/04/18 19:17:19]

Done.

+  chromeos::CrosSettings* cros_settings = chromeos::CrosSettings::Get();

[Mattias Nissler (ping if slow), 2013/04/18 10:39:39]

Sigh, CrosSettings mocking still sucks. Sorry about that.

[Mathieu, 2013/04/18 19:17:19]

Hey at least it works ;)

+  // Remove the real DeviceSettingsProvider and replace it with a stub that
+  // allows modifications in a test.
+  chromeos::CrosSettingsProvider* device_settings_provider =
+    cros_settings->GetProvider(chromeos::kReportDeviceVersionInfo);

[Alexei Svitkine (slow), 2013/04/17 21:24:36]

Indent 2 more.

[Mathieu, 2013/04/18 19:17:19]

Done.

+  EXPECT_TRUE(device_settings_provider != NULL);
+  EXPECT_TRUE(cros_settings->RemoveSettingsProvider(device_settings_provider));
+  cros_settings->AddSettingsProvider(&stub_settings_provider);
+
+  cros_settings->SetString(chromeos::kVariationsRestrictParameter,
+                           "restricted");
+#else
   prefs.SetString(prefs::kVariationsRestrictParameter, "restricted");
+#endif
+
   EXPECT_EQ(default_variations_url + "?restrict=restricted",
             VariationsService::GetVariationsServerURL(&prefs).spec());
+
+#if defined(OS_CHROMEOS)
+  // Restore the real DeviceSettingsProvider.
+  EXPECT_TRUE(
+    cros_settings->RemoveSettingsProvider(&stub_settings_provider));

[Alexei Svitkine (slow), 2013/04/17 21:24:36]

Indent 2 more.

[Mathieu, 2013/04/18 19:17:19]

Done.

+  cros_settings->AddSettingsProvider(device_settings_provider);
+#endif
 }
 
 TEST(VariationsServiceTest, LoadSeed) {
   // Store good seed data to test if loading from prefs works.
   const TrialsSeed seed = CreateTestSeed();
   const std::string base64_seed = SerializeSeedBase64(seed);
 
   TestingPrefServiceSimple prefs;
   VariationsService::RegisterPrefs(prefs.registry());
   prefs.SetString(prefs::kVariationsSeed, base64_seed);
@@ skipping 207 matching lines @@
 
     net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
     SimulateServerResponse(non_ok_status_codes[i], fetcher);
     variations_service.OnURLFetchComplete(fetcher);
 
     EXPECT_TRUE(prefs.FindPreference(prefs::kVariationsSeed)->IsDefaultValue());
   }
 }
 
 }  // namespace chrome_variations