Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1426743002: Add lock owner information for class Monitor and add assertions for wait/notify/notifyall. (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add lock owner information for class Monitor and add assertions for wait/notify/notifyall. R=johnmccutchan@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/1a038d5030e4b96b8f37e3a6ed858375b6c2c12d

Patch Set 1 #

Patch Set 2 : self-review-comments #

Total comments: 12

Patch Set 3 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -36 lines) Patch
M runtime/vm/os_thread.h View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_android.cc View 1 2 9 chunks +45 lines, -10 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 2 8 chunks +47 lines, -11 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 2 9 chunks +45 lines, -10 lines 0 comments Download
M runtime/vm/os_thread_win.cc View 1 2 10 chunks +44 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
siva
5 years, 1 month ago (2015-10-26 22:55:05 UTC) #2
Cutch
LGTM with a small suggestion https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_win.cc File runtime/vm/os_thread_win.cc (right): https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_win.cc#newcode510 runtime/vm/os_thread_win.cc:510: ASSERT(IsOwnedByCurrentThread()); #if defined(DEBUG) is ...
5 years, 1 month ago (2015-10-26 23:00:50 UTC) #3
srdjan
lgtm https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_android.cc File runtime/vm/os_thread_android.cc (right): https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_android.cc#newcode379 runtime/vm/os_thread_android.cc:379: owner_ = OSThread::GetCurrentThreadId(); Do you need to check ...
5 years, 1 month ago (2015-10-26 23:02:11 UTC) #4
siva
https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_android.cc File runtime/vm/os_thread_android.cc (right): https://chromiumcodereview.appspot.com/1426743002/diff/20001/runtime/vm/os_thread_android.cc#newcode379 runtime/vm/os_thread_android.cc:379: owner_ = OSThread::GetCurrentThreadId(); On 2015/10/26 23:02:11, srdjan wrote: > ...
5 years, 1 month ago (2015-10-27 00:14:57 UTC) #5
siva
5 years, 1 month ago (2015-10-27 20:47:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1a038d5030e4b96b8f37e3a6ed858375b6c2c12d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698