Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 14267032: Omnibox: HistoryContents Shouldn't *Always* Clear Results on Stop() (Closed)

Created:
7 years, 8 months ago by Mark P
Modified:
7 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Omnibox: HistoryContents Shouldn't *Always* Clear Results on Stop() It should only clear results if asked to. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/autocomplete/history_contents_provider.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mark P
7 years, 8 months ago (2013-04-19 20:43:42 UTC) #1
Peter Kasting
LGTM
7 years, 8 months ago (2013-04-19 20:50:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/14267032/1
7 years, 8 months ago (2013-04-19 21:10:00 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 21:25:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/14267032/1
7 years, 8 months ago (2013-04-19 21:32:38 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 21:43:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/14267032/1
7 years, 8 months ago (2013-04-22 16:47:16 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 17:43:55 UTC) #8
Message was sent while issue was closed.
Change committed as 195547

Powered by Google App Engine
This is Rietveld 408576698