Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: Source/modules/indexeddb/IDBRequest.cpp

Issue 14267029: Prepare to eliminate WebDOMStringList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix names duplication in conversion Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/indexeddb/IDBRequest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBRequest.cpp
diff --git a/Source/modules/indexeddb/IDBRequest.cpp b/Source/modules/indexeddb/IDBRequest.cpp
index 90f160ad325f0a48d7c6258629e295cc2b087306..d9cc6dd7669032e9ccbb434aa12ad9d7029c2c53 100644
--- a/Source/modules/indexeddb/IDBRequest.cpp
+++ b/Source/modules/indexeddb/IDBRequest.cpp
@@ -275,13 +275,16 @@ static PassRefPtr<Event> createSuccessEvent()
return Event::create(eventNames().successEvent, false, false);
}
-void IDBRequest::onSuccess(PassRefPtr<DOMStringList> domStringList)
+void IDBRequest::onSuccess(const Vector<String>& stringList)
{
- IDB_TRACE("IDBRequest::onSuccess(DOMStringList)");
+ IDB_TRACE("IDBRequest::onSuccess(StringList)");
if (!shouldEnqueueEvent())
return;
- m_result = IDBAny::create(domStringList);
+ RefPtr<DOMStringList> domStringList = DOMStringList::create();
+ for (size_t i = 0; i < stringList.size(); ++i)
+ domStringList->append(stringList[i]);
+ m_result = IDBAny::create(domStringList.release());
enqueueEvent(createSuccessEvent());
}
« no previous file with comments | « Source/modules/indexeddb/IDBRequest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698