Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14267029: Prepare to eliminate WebDOMStringList (Closed)

Created:
7 years, 8 months ago by alecflett
Modified:
7 years, 8 months ago
Reviewers:
jsbell, abarth-chromium
CC:
blink-reviews, jamesr, dgrogan, alecflett, jsbell, abarth_chromum.org
Visibility:
Public.

Description

Prepare to eliminate WebDOMStringList IDB uses WebDOMStringList in its backend, where a WebVector<WebString> would suffice. This is the first part of a blink/chromium/blink 3-sided patch. BUG=233361 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148770

Patch Set 1 #

Total comments: 2

Patch Set 2 : little hack to make landing cleaner #

Patch Set 3 : fix names duplication in conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -23 lines) Patch
M Source/WebKit/chromium/public/WebIDBCallbacks.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M Source/WebKit/chromium/public/WebIDBDatabase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/public/WebIDBFactory.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/IDBCallbacksProxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/IDBCallbacksProxy.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebIDBCallbacksImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebIDBCallbacksImpl.cpp View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/IDBDatabaseBackendTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/IDBRequestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCallbacks.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBFactoryBackendImpl.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
alecflett
Another one of these, pretty mechanical.
7 years, 8 months ago (2013-04-19 18:54:02 UTC) #1
jsbell
lgtm https://codereview.chromium.org/14267029/diff/1/Source/WebKit/chromium/src/IDBCallbacksProxy.h File Source/WebKit/chromium/src/IDBCallbacksProxy.h (right): https://codereview.chromium.org/14267029/diff/1/Source/WebKit/chromium/src/IDBCallbacksProxy.h#newcode32 Source/WebKit/chromium/src/IDBCallbacksProxy.h:32: #include "DOMStringList.h" Why is this needed in this ...
7 years, 8 months ago (2013-04-19 19:06:25 UTC) #2
abarth-chromium
API change LGTM
7 years, 8 months ago (2013-04-19 19:19:24 UTC) #3
alecflett
https://codereview.chromium.org/14267029/diff/1/Source/WebKit/chromium/src/IDBCallbacksProxy.h File Source/WebKit/chromium/src/IDBCallbacksProxy.h (right): https://codereview.chromium.org/14267029/diff/1/Source/WebKit/chromium/src/IDBCallbacksProxy.h#newcode32 Source/WebKit/chromium/src/IDBCallbacksProxy.h:32: #include "DOMStringList.h" On 2013/04/19 19:06:25, jsbell wrote: > Why ...
7 years, 8 months ago (2013-04-19 20:12:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14267029/1
7 years, 8 months ago (2013-04-19 20:12:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14267029/17
7 years, 8 months ago (2013-04-19 20:14:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4544
7 years, 8 months ago (2013-04-19 20:48:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14267029/17
7 years, 8 months ago (2013-04-19 21:09:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=4561
7 years, 8 months ago (2013-04-19 22:02:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14267029/18001
7 years, 8 months ago (2013-04-19 23:05:14 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-20 02:31:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 148770

Powered by Google App Engine
This is Rietveld 408576698