Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 14267013: Replaces the web notification button image for ChromeOS. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
stevenjb, oshima
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, dewittj
Visibility:
Public.

Description

Replaces the web notification button image for ChromeOS. BUG=189129 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195310

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-12 lines, --12 lines) Patch
M ash/resources/default_100_percent/common/notification/notification_button_active_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/notification/notification_button_active_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/notification/notification_button_active_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/notification/notification_button_inactive_hover.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/notification/notification_button_inactive_normal.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_100_percent/common/notification/notification_button_inactive_pressed.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_active_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_active_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_active_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_inactive_hover.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_inactive_normal.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M ash/resources/default_200_percent/common/notification/notification_button_inactive_pressed.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
7 years, 8 months ago (2013-04-19 03:36:29 UTC) #1
Jun Mukai
cc to dewittj FYI
7 years, 8 months ago (2013-04-19 03:37:02 UTC) #2
stevenjb
lgtm
7 years, 8 months ago (2013-04-19 20:56:39 UTC) #3
Jun Mukai
udpated the image due to a talk with PM. submitting with TBR=oshima.
7 years, 8 months ago (2013-04-19 22:17:26 UTC) #4
Jun Mukai
Committed patchset #2 manually as r195310 (presubmit successful).
7 years, 8 months ago (2013-04-19 22:18:45 UTC) #5
oshima
7 years, 8 months ago (2013-04-19 22:27:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698