views: Fix crash in NativeMenuWin::AddMenuItemAt().

views: Fix crash in NativeMenuWin::AddMenuItemAt().

BUG=233243
R=msw@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195033

[tfarina, 2013-04-18 21:34:32]

Mike, could you see if this fixes the crash on Windows?

Thanks,

[msw, 2013-04-18 21:42:39]

I'm not an expert here, but that seems reasonable.
Please TBR Scott or have Ben take a look; thanks.

[tfarina, 2013-04-18 21:58:36]

Ben, this is urgent (high number of crashes)! Could you take a look?

Note: Mike is trying to verify the fix, I don't have a Windows box to try it. It
seems you can trigger this menu from an app or a window or even from the context
menu that shows the taskmanager item.

Thanks!

[tfarina, 2013-04-19 00:52:07]

Ben, Mike is monitoring go/crashes and we need this in canary to verify the fix.

I have a green light from Mike, so I'm going to land this manually.

If this doesn't fix the crash I'll revert both.

[tfarina, 2013-04-19 00:53:10]

Committed patchset #1 manually as r195033 (presubmit successful).

[msw, 2013-04-19 00:53:13]

I would TBR Scott and try to land this to see if it fixes tomorrow's canary.
Since no one can explicitly repro the crash, that might be a worthwhile gamble
to avoid the crashes and keep your http://crrev.com/194356 intact. I'll check
for crashes on the next canary after this lands, and if they're still present we
can revert both CLs. So, LGTM.

[tfarina, 2013-04-19 00:58:31]

I should have copied Scott too since he reviewed the original CL! :(

Since he was out of office, I sent this to Ben, so he can take a look at this
tomorrow.

And now, Scott on Monday.

My mistake!

[Ben Goodger (Google), 2013-04-19 16:17:33]

lgtm