Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1426673005: Introduce LayoutBox::paginationBreakability(). (Closed)

Created:
5 years, 1 month ago by mstensho (USE GERRIT)
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce LayoutBox::paginationBreakability(). The engine actually cares about three states of column / page breakability inside an object: 1. Breakable. Look inside for possible break points. 2. Unbreakable. Breaking inside would pretty much guarantee ugly layout. 3. Preferable not to break (break-inside:avoid). LayoutBox::isUnsplittableForPagination() returned true for #2, and false for #1 and #3. The only one that cares about #3 at the moment is adjustForUnsplittableChild() in LayoutBlockFlow, which handled #3 on its own after checking with isUnsplittableForPagination(), but we're soon going to have to care about it at other places too, so let's introduce a method that can tell us. R=leviw@chromium.org Committed: https://crrev.com/67fa0a7acb5a84802c2da62aec914697f13e9e72 Cr-Commit-Position: refs/heads/master@{#357559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M third_party/WebKit/Source/core/layout/ColumnBalancer.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 1 month ago (2015-11-03 14:16:02 UTC) #1
leviw_travelin_and_unemployed
lgtm
5 years, 1 month ago (2015-11-03 17:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426673005/1
5 years, 1 month ago (2015-11-03 17:10:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 18:21:54 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 18:23:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67fa0a7acb5a84802c2da62aec914697f13e9e72
Cr-Commit-Position: refs/heads/master@{#357559}

Powered by Google App Engine
This is Rietveld 408576698