Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1426673003: Stage ES2015 ToLength semantics (Closed)

Created:
5 years, 1 month ago by Dan Ehrenberg
Modified:
5 years, 1 month ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage ES2015 ToLength semantics Many places in the JavaScript standard library are changed in ES2015 from getting an integer using ToUint32 to using ToLength. This patch stages the flag turning on those new semantics. BUG=v8:3087, v8:4244 LOG=Y R=adamk Committed: https://crrev.com/7736f47460683dad84e77d1123c32487921d1a89 Cr-Commit-Position: refs/heads/master@{#31641}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -67 lines) Patch
M src/flag-definitions.h View 1 2 chunks +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 3 chunks +2 lines, -66 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426673003/1
5 years, 1 month ago (2015-10-27 05:24:15 UTC) #2
Dan Ehrenberg
5 years, 1 month ago (2015-10-27 05:24:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-27 05:52:37 UTC) #5
adamk
lgtm https://codereview.chromium.org/1426673003/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1426673003/diff/1/test/test262/test262.status#newcode560 test/test262/test262.status:560: # https://code.google.com/p/v8/issues/detail?id=4516 Presumably we'll still want to skip ...
5 years, 1 month ago (2015-10-27 17:57:43 UTC) #6
adamk
Maybe this should wait until you land a fix for the %AddElement thing, otherwise we're ...
5 years, 1 month ago (2015-10-27 18:02:52 UTC) #7
Dan Ehrenberg
On 2015/10/27 at 18:02:52, adamk wrote: > Maybe this should wait until you land a ...
5 years, 1 month ago (2015-10-27 18:08:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426673003/1
5 years, 1 month ago (2015-10-28 20:41:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9547) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 1 month ago (2015-10-28 20:42:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426673003/20001
5 years, 1 month ago (2015-10-28 20:53:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 21:14:36 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 21:15:08 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7736f47460683dad84e77d1123c32487921d1a89
Cr-Commit-Position: refs/heads/master@{#31641}

Powered by Google App Engine
This is Rietveld 408576698