Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6762)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 1426663005: Make the histograms for setting the default browser consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index ab08941ddff6b200a15a71c5a05e3972ee17b16e..50a066874ab126ebc3e0e141f1a3012aa97d1043 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -1135,8 +1135,14 @@ void BrowserOptionsHandler::BecomeDefaultBrowser(const base::ListValue* args) {
return;
content::RecordAction(UserMetricsAction("Options_SetAsDefaultBrowser"));
- default_browser_worker_->StartSetAsDefault();
+ UMA_HISTOGRAM_ENUMERATION(
+ "SetDefaultBrowser.Location",
+ ShellIntegration::SetDefaultBrowserLocation::SETTINGS,
+ ShellIntegration::SetDefaultBrowserLocation::
+ NUM_SET_DEFAULT_BROWSER_LOCATION_TYPES);
+
// Callback takes care of updating UI.
+ default_browser_worker_->StartSetAsDefault();
// If the user attempted to make Chrome the default browser, notify
// them when this changes.

Powered by Google App Engine
This is Rietveld 408576698