chrome/browser/ui/browser_command_controller.cc - Issue 1426663005: Make the histograms for setting the default browser consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1426663005: Make the histograms for setting the default browser consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/shell_integration.cc ('K') | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/ui/startup/default_browser_prompt.cc » ('j') | chrome/browser/ui/startup/default_browser_prompt.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index a87d2e9dd83e5c186e8b86257c000e2458f3dfa0..6499817aa7e66e2b317b460d9228bf5fa8b0270a 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/browser_command_controller.h"

+#include <string>

#include "base/command_line.h"

#include "base/prefs/pref_service.h"

#include "chrome/app/chrome_command_ids.h"

@@ -165,7 +167,6 @@ class SwitchToMetroUIHandler

return;

}

first_check_ = false;

- default_browser_worker_->StartCheckIsDefault();

grt (UTC plus 2) 2015/11/03 21:12:22 huh. was this never needed?

Patrick Monette 2015/11/10 19:22:47 StartCheckIsDefault() is already called in OnSetAs

}

bool IsInteractiveSetDefaultPermitted() override {