Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 1426663005: Make the histograms for setting the default browser consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed name collision Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/startup/default_browser_prompt.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 095cb140bad0edcd1256c1aded02dabeda9cd85e..b8159ebeaa55ef57f290c3ca319b73bca1b4507a 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -1083,8 +1083,10 @@ void BrowserOptionsHandler::BecomeDefaultBrowser(const base::ListValue* args) {
return;
content::RecordAction(UserMetricsAction("Options_SetAsDefaultBrowser"));
- default_browser_worker_->StartSetAsDefault();
+ UMA_HISTOGRAM_COUNTS("Settings.StartSetAsDefault", true);
+
// Callback takes care of updating UI.
+ default_browser_worker_->StartSetAsDefault();
// If the user attempted to make Chrome the default browser, notify
// them when this changes.
« no previous file with comments | « chrome/browser/ui/startup/default_browser_prompt.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698