chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 1426663005: Make the histograms for setting the default browser consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 1426663005: Make the histograms for setting the default browser consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix wrong comment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/default_browser_prompt.cc ('K') | « chrome/browser/ui/startup/default_browser_prompt.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index 095cb140bad0edcd1256c1aded02dabeda9cd85e..b8159ebeaa55ef57f290c3ca319b73bca1b4507a 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -1083,8 +1083,10 @@ void BrowserOptionsHandler::BecomeDefaultBrowser(const base::ListValue* args) {

return;

content::RecordAction(UserMetricsAction("Options_SetAsDefaultBrowser"));

- default_browser_worker_->StartSetAsDefault();

+ UMA_HISTOGRAM_COUNTS("Settings.StartSetAsDefault", true);

// Callback takes care of updating UI.

+ default_browser_worker_->StartSetAsDefault();

// If the user attempted to make Chrome the default browser, notify

// them when this changes.