Make the histograms for setting the default browser consistent

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b7dc4b061ea6d2b4b1a840df05526ce4e861dcff..c004402764d357bd073f361de84287a575431853 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -6291,6 +6291,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 
 <histogram name="DefaultBrowser.AsyncSetAsDefault.Duration"
     units="milliseconds">
+  <obsolete>
+    Deprecated 2015/11. Renamed to SetDefaultBrowser.AsyncDuration.
+  </obsolete>
   <owner>pmonette@chromium.org</owner>
   <summary>
     How long it took to set Chrome as the default browser asynchronously in
@@ -6301,6 +6304,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 
 <histogram name="DefaultBrowser.AsyncSetAsDefault.Result"
     enum="DefaultBrowserAsyncAttemptResult">
+  <obsolete>
+    Deprecated 2015/11. Renamed to SetDefaultBrowser.Result.
+  </obsolete>
   <owner>pmonette@chromium.org</owner>
   <summary>
     The count of how many times users were successfully able to set Chrome as
@@ -6308,6 +6314,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="DefaultBrowser.InfoBar.Ignored" enum="BooleanHit">

[rkaplow, 2015/11/11 15:54:00]

for this and all histograms in this CL that are Windows only - can you mark that
in the description?

[Patrick Monette, 2015/11/11 22:03:35]

Most of the histograms are now for all platforms that uses the worker. Only the
DefaultBrowser.SetDefaultAsyncDuration one is windows specific.

+  <owner>gab@chromium.org</owner>
+  <summary>
+    The user ignored the make-default infobar (it was eventually dismissed along
+    with its associated web content without the user interacting with it).
+  </summary>
+</histogram>
+
+<histogram name="DefaultBrowser.InfoBar.StartSetAsDefault" enum="BooleanHit">

[rkaplow, 2015/11/11 15:54:00]

is there any other options on the inforbar we should be tracking through this?

[Patrick Monette, 2015/11/11 22:03:35]

I added the "Don't ask again" button.

+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    The user clicked &quot;Set as default&quot; on the default browser info bar.
+  </summary>
+</histogram>
+
 <histogram name="DefaultBrowser.InteractionResult"
     enum="MakeChromeDefaultResult">
   <owner>gab@chromium.org</owner>
@@ -6322,6 +6343,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="DefaultBrowserWarning.DontSetAsDefault" enum="BooleanHit">
+  <obsolete>
+    Deprecated 2015/11. The same information is available in
+    SetDefaultBrowser.Result.

[grt (UTC plus 2), 2015/11/10 20:04:30]

which value?

[Patrick Monette, 2015/11/11 22:03:35]

Done.

+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     In the make-default infobar, the user explicitly declined to set Chrome as
@@ -6332,6 +6357,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="DefaultBrowserWarning.Ignored" enum="BooleanHit">
+  <obsolete>
+    Deprecated 2015/11. Renamed to SetDefaultBrowser.InfoBar.Ignored.
+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     The user ignored the make-default infobar (it was eventually dismissed along
@@ -6340,6 +6368,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="DefaultBrowserWarning.SetAsDefault" enum="BooleanHit">
+  <obsolete>
+    Deprecated 2015/11. Changed to a user action named
+    DefaultBrowserInfoBar_Accept.
+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     In the make-default infobar, the user clicked a button making Chrome the
@@ -6348,6 +6380,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="DefaultBrowserWarning.SetAsDefaultUI" enum="BooleanHit">

[rkaplow, 2015/11/11 15:54:00]

there's advantages to having histograms as well. I would suggest leaving enum
histrograms tracking key decision points.
It's ok information being tracked by both user actions and histograms.

[Patrick Monette, 2015/11/11 22:03:35]

Changed the comment. There is an histogram for this now.

+  <obsolete>
+    Deprecated 2015/11. Changed to a user action named
+    DefaultBrowserInfoBar_Accept.
+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     Same as SetAsDefault, but in Win8+ (resulting in interactive UI instead of
@@ -6358,6 +6394,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </histogram>
 
 <histogram name="DefaultBrowserWarning.SetAsDefaultUIFailed" enum="BooleanHit">
+  <obsolete>
+    Deprecated 2015/11. The same information is available in
+    SetDefaultBrowser.Result.

[grt (UTC plus 2), 2015/11/10 20:04:30]

which value?

[Patrick Monette, 2015/11/11 22:03:35]

Done.

+  </obsolete>
   <owner>gab@chromium.org</owner>
   <summary>
     The user dismissed the interactive SetAsDefaultUI without making an explicit
@@ -41708,6 +41748,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="SetDefaultBrowser.AsyncDuration" units="milliseconds">

[rkaplow, 2015/11/11 15:54:00]

also, I would group all your histograms together in the same top level group.

DefaultBrowser seems reasonable to me. This way people looking into these
metrics will be able to look in one consistent namespace.

[Patrick Monette, 2015/11/11 22:03:35]

Done.

+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    How long it took to set Chrome as the default browser asynchronously in
+    Windows 10+. The duration is recorded only on Success, Failure, Abandoned,
+    Retry and NoErrorsNotDefault result codes.
+  </summary>
+</histogram>
+
+<histogram name="SetDefaultBrowser.Result" enum="SetDefaultAttemptResult">
+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    The count of how many times users were successfully able to set Chrome as

[grt (UTC plus 2), 2015/11/10 20:04:30]

trust rkaplow with whatever he says in case he disagrees with me here: i think
this should be more along the lines of "The outcome of an attempt to set Chrome
as the user's default browser." similarly for SetDefaultProtocolClient below.

[rkaplow, 2015/11/11 15:54:00]

Agreed.

[Patrick Monette, 2015/11/11 22:03:35]

Done.

+    the default browser.
+  </summary>
+</histogram>
+
+<histogram name="SetDefaultProtocolClient.Result"
+    enum="SetDefaultAttemptResult">
+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    The count of how many times users were successfully able to set Chrome as a
+    default protocol client.
+  </summary>
+</histogram>
+
 <histogram name="Settings.DefaultSearchProvider" enum="OmniboxSearchEngine">
   <obsolete>
     Deprecated in Chrome 30.  Use Search.DefaultSearchProviderType instead.
@@ -41905,6 +41971,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Settings.StartSetAsDefault" enum="BooleanHit">
+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    The user clicked &quot;Make Google Chrome the default browser&quot; on the
+    settings page.
+  </summary>
+</histogram>
+
 <histogram name="Settings.StartupPageDomains" enum="OmniboxSearchEngine">
   <obsolete>
     Deprecated in Chrome 30.  Replaced by Settings.StartupPageEngineTypes.
@@ -55680,6 +55754,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
 </enum>
 
 <enum name="DefaultBrowserAsyncAttemptResult" type="int">
+  <obsolete>
+    Deprecated 2015/11. Renamed to SetDefaultAttemptResult.
+  </obsolete>
   <int value="0" label="Success">No errors encountered.</int>
   <int value="1" label="Already default">
     Chrome was already the default web client. This counts as a successful
@@ -71915,6 +71992,34 @@ To add a new entry, add it with any value and run test to compute valid value.
   </int>
 </enum>
 
+<enum name="SetDefaultAttemptResult" type="int">
+  <int value="0" label="Success">Chrome was set as the default web client.</int>
+  <int value="1" label="Already default">
+    Chrome was already the default web client. This counts as a successful
+    attempt.
+  </int>
+  <int value="2" label="Failure">
+    Chrome was not set as the default web client.
+  </int>
+  <int value="3" label="Abandoned">
+    The attempt was abandoned because the observer was destroyed.
+  </int>
+  <int value="4" label="Launch failure">
+    Failed to launch the process to set Chrome as the default web client
+    asynchronously.
+  </int>
+  <int value="5" label="Other worker">
+    Another worker is already in progress to make Chrome the default web client.
+  </int>
+  <int value="6" label="Retry">
+    The user initiated another attempt while the asynchronous operation was
+    already in progress.
+  </int>
+  <int value="7" label="No errors, not default">
+    No errors were encountered yet Chrome is still not the default web client.
+  </int>
+</enum>
+
 <enum name="SHA1Status" type="int">
   <summary>
     Whether or not SHA-1 was present in a certificate chain and, if it was, when
@@ -75661,6 +75766,9 @@ To add a new entry, add it with any value and run test to compute valid value.
 </histogram_suffixes>
 
 <histogram_suffixes name="AttemptResultCode">
+  <obsolete>
+    Deprecated 2015/11. Renamed to AttemptResultCode2.

[grt (UTC plus 2), 2015/11/10 20:04:30]

this needs to be deprecated and a new suffix set created because the
affected-histogram's name changed?

[Patrick Monette, 2015/11/11 22:03:35]

Robert? Do I need to do it? I was concerned with having an obsolete histogram no
longer having its histogram_suffixes in this file.

[rkaplow, 2015/11/13 15:56:14]

It should be fine, you can just leave the obsolete
DefaultBrowser.SetDefaultAsyncDuration within the affected histograms here.

[Patrick Monette, 2015/11/16 17:29:05]

Done.

+  </obsolete>
   <suffix name="Success"/>
   <suffix name="Failure"/>
   <suffix name="Abandoned"/>
@@ -75668,6 +75776,15 @@ To add a new entry, add it with any value and run test to compute valid value.
   <affected-histogram name="DefaultBrowser.AsyncSetAsDefault.Duration"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="AttemptResultCode2">
+  <suffix name="Success"/>
+  <suffix name="Failure"/>
+  <suffix name="Abandoned"/>
+  <suffix name="Retry"/>
+  <suffix name="NoErrorsNotDefault"/>
+  <affected-histogram name="SetDefaultBrowser.AsyncDuration"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="AutofillDataAvailability" separator=".">
   <suffix name="WithNoData" label="no autofill data"/>
   <suffix name="WithOnlyServerData" label="only server autofill data"/>