Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/vm/cpu_arm.cc

Issue 142663004: Reverts refactoring of CPU feature detection for (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/cpu_arm.h ('k') | runtime/vm/cpu_ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/cpu_arm.cc
===================================================================
--- runtime/vm/cpu_arm.cc (revision 32559)
+++ runtime/vm/cpu_arm.cc (working copy)
@@ -6,15 +6,13 @@
#if defined(TARGET_ARCH_ARM)
-#include "vm/cpu.h"
-#include "vm/cpuinfo.h"
-#include "vm/simulator.h"
-
#if defined(HOST_ARCH_ARM)
#include <sys/syscall.h> /* NOLINT */
#include <unistd.h> /* NOLINT */
#endif
+#include "vm/cpu.h"
+
namespace dart {
void CPU::FlushICache(uword start, uword size) {
@@ -50,53 +48,6 @@
"arm";
}
-
-bool HostCPUFeatures::integer_division_supported_ = false;
-bool HostCPUFeatures::neon_supported_ = false;
-char* HostCPUFeatures::hardware_ = NULL;
-#if defined(DEBUG)
-bool HostCPUFeatures::initialized_ = false;
-#endif
-
-
-#if defined(HOST_ARCH_ARM)
-void HostCPUFeatures::InitOnce() {
- CpuInfo::InitOnce();
- hardware_ = CpuInfo::GetCpuModel();
- // Implements ARMv7.
- ASSERT(CpuInfo::FieldContainsById(CpuInfo::kCpuInfoProcessor, "ARMv7"));
- // Has floating point unit.
- ASSERT(CpuInfo::FieldContainsById(CpuInfo::kCpuInfoFeatures, "vfp"));
- // Has integer division.
- bool is_krait =
- CpuInfo::FieldContainsById(CpuInfo::kCpuInfoModel, "QCT APQ8064");
- if (is_krait) {
- // Special case for Qualcomm Krait CPUs in Nexus 4 and 7.
- integer_division_supported_ = true;
- } else {
- integer_division_supported_ =
- CpuInfo::FieldContainsById(CpuInfo::kCpuInfoFeatures, "idiva");
- }
- neon_supported_ =
- CpuInfo::FieldContainsById(CpuInfo::kCpuInfoFeatures, "neon");
-#if defined(DEBUG)
- initialized_ = true;
-#endif
-}
-
-#else
-
-void HostCPUFeatures::InitOnce() {
- CpuInfo::InitOnce();
- hardware_ = CpuInfo::GetCpuModel();
- integer_division_supported_ = true;
- neon_supported_ = true;
-#if defined(DEBUG)
- initialized_ = true;
-#endif
-}
-#endif // defined(HOST_ARCH_ARM)
-
} // namespace dart
#endif // defined TARGET_ARCH_ARM
« no previous file with comments | « runtime/vm/cpu_arm.h ('k') | runtime/vm/cpu_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698