Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 1426623002: GN: mark newlib_pnacl toolchain as clang (Closed)

Created:
5 years, 1 month ago by Petr Hosek
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: mark newlib_pnacl toolchain as clang newlib_pnacl toolchain is based on clang so it should be marked as such to use the correct cflags. BUG=462791 Committed: https://crrev.com/33dd52f8995f6605cf7d1858f95b5e9cd98a5a09 Cr-Commit-Position: refs/heads/master@{#356098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/toolchain/nacl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Petr Hosek
5 years, 1 month ago (2015-10-25 20:40:09 UTC) #3
Roland McGrath
lgtm
5 years, 1 month ago (2015-10-26 18:53:08 UTC) #4
Dirk Pranke
lgtm
5 years, 1 month ago (2015-10-26 18:54:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426623002/1
5 years, 1 month ago (2015-10-26 19:03:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 19:35:11 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 19:35:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33dd52f8995f6605cf7d1858f95b5e9cd98a5a09
Cr-Commit-Position: refs/heads/master@{#356098}

Powered by Google App Engine
This is Rietveld 408576698