Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1426583008: Merge WebUSB notification flag into experimental web platform features. (Closed)

Created:
5 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge WebUSB notification flag into experimental web platform features. The WebUSB notification flag tells Chrome to scan for WebUSB-enabled devices when they are connected to the system. This patch will expose this code to a larger population to make sure that such scanning does not introduce new crashes and reduce the number of flags developers must enable to try out WebUSB. BUG=492204 Committed: https://crrev.com/d58e643f244fea3c9ab3a03d306414cbf48b5a20 Cr-Commit-Position: refs/heads/master@{#357639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 1 month ago (2015-10-30 22:37:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-03 07:16:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426583008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426583008/1
5 years, 1 month ago (2015-11-03 20:14:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 21:43:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 21:45:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d58e643f244fea3c9ab3a03d306414cbf48b5a20
Cr-Commit-Position: refs/heads/master@{#357639}

Powered by Google App Engine
This is Rietveld 408576698