Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1426583002: [turbofan] Centralize splitting for memory operands. (Closed)

Created:
5 years, 2 months ago by Mircea Trofin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Centralize splitting for memory operands. This addresses an issue where the at-start splitting used in the splintering mechanism was in conflict with the mechanics used in linear allocator, in particular in the initial split/spill of ranges for memory operands. We are already doing a split-at-start in Greedy, so this change centralizes that to the base RegisterAllocator. Verified locally that v8:4508 is addressed by this. Also, this fixes the failures that required the revert 5308a999eb3540c3ca19d4ba08d788a4970431e8. See trybots at issue 1425533002. R=bmeurer@chromium.org,jarin@chromium.org BUG=v8:4508 LOG=n Committed: https://crrev.com/0b0249582a7dd595cef62eb8897449ac1627d737 Cr-Commit-Position: refs/heads/master@{#31544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -62 lines) Patch
M src/compiler/greedy-allocator.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 2 chunks +0 lines, -50 lines 0 comments Download
M src/compiler/register-allocator.h View 3 chunks +17 lines, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 3 chunks +65 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
5 years, 1 month ago (2015-10-26 02:39:58 UTC) #4
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-10-26 04:40:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426583002/1
5 years, 1 month ago (2015-10-26 04:41:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 05:02:38 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 05:03:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b0249582a7dd595cef62eb8897449ac1627d737
Cr-Commit-Position: refs/heads/master@{#31544}

Powered by Google App Engine
This is Rietveld 408576698