Source/core/css/resolver/StyleResolver.cpp - Issue 142653003: Retry "Replace RenderFullScreen with top layer"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 142653003: Retry "Replace RenderFullScreen with top layer" (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: new revised patch Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleResolver.cpp

diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp

index 9ef098decd20a0d3ba192f02d25b35f67ba5364f..f47fd6242b37f8e8d0f7ee6840e6b51746b8256c 100644

--- a/Source/core/css/resolver/StyleResolver.cpp

+++ b/Source/core/css/resolver/StyleResolver.cpp

@@ -880,7 +880,9 @@ PassRefPtr<PseudoElement> StyleResolver::createPseudoElementIfNeeded(Element& pa

if (pseudoId == BACKDROP && !parent.isInTopLayer())

return 0;

- if (!parentRenderer->canHaveGeneratedChildren())

+ // It's safe to have a backdrop since its renderer is always a child of RenderView.

+ ASSERT(static_cast<RenderObject*>(parentRenderer->view())->canHaveGeneratedChildren());

+ if (pseudoId != BACKDROP && !parentRenderer->canHaveGeneratedChildren())

return 0;

RenderStyle* parentStyle = parentRenderer->style();