Retry "Replace RenderFullScreen with top layer"

Retry "Replace RenderFullScreen with top layer"

This patch makes the Fullscreen API use the top layer, as per the latest
Fullscreen spec. This retry fixes some tests/expectations.

Previously landed as r165904 and r165710
Codereviews:
https://codereview.chromium.org/134753003/
https://codereview.chromium.org/139743005/

BUG=240576, 246077

[Rick Byers, 2014-01-30 03:49:38]

FYI, I've got the ScrollingCoordinator fix in the CQ here:
https://codereview.chromium.org/129813009/.  You can remove it from this CL
before landing.

[falken, 2014-01-30 04:42:51]

Thanks Rick!

Elliott, can you review again please? This should be ready to land after Rick's
patch lands.

Fixes from last time:
- fullscreen/parent-flow-inline-with-block-child.html: image and text fails
while waiting for the manual baseline, so I changed ImageOnlyFailure to Failure
expectation
- fullscreen/anonymous-block-merge-crash.html: was failing due to a race.
Changed to wait for the cancel fullscreen to finish before calling
testRunner.notifyDone()
- virtual/android/fullscreen/full-screen-iframe-legacy.html: should be fixed
after patch for http://crbug.com/339141 lands. 
- plugin-document-back-forward.html: it turns out this was unrelated. It is
still flakily failing after the revert.

[esprehn, 2014-01-30 04:52:21]

lgtm

https://codereview.chromium.org/142653003/diff/180001/Source/core/dom/Fullscr...
File Source/core/dom/FullscreenElementStack.cpp (right):

https://codereview.chromium.org/142653003/diff/180001/Source/core/dom/Fullscr...
Source/core/dom/FullscreenElementStack.cpp:265: for (Vector<RefPtr<Element>
>::iterator iter = topFullscreenElementStack->m_fullScreenElementStack.begin();
iter + 1 < end; ++iter) {
it =, we don't usually use "iter"

[falken, 2014-01-30 05:06:29]

Thanks for the speedy review!

https://codereview.chromium.org/142653003/diff/180001/Source/core/dom/Fullscr...
File Source/core/dom/FullscreenElementStack.cpp (right):

https://codereview.chromium.org/142653003/diff/180001/Source/core/dom/Fullscr...
Source/core/dom/FullscreenElementStack.cpp:265: for (Vector<RefPtr<Element>
>::iterator iter = topFullscreenElementStack->m_fullScreenElementStack.begin();
iter + 1 < end; ++iter) {
On 2014/01/30 04:52:22, esprehn wrote:
> it =, we don't usually use "iter"

Done.

[commit-bot: I haz the power, 2014-01-30 06:34:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/142653003/120002

[commit-bot: I haz the power, 2014-01-30 08:43:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/142653003/120002

[commit-bot: I haz the power, 2014-01-30 09:38:30]

Change committed as 166114

[commit-bot: I haz the power, 2014-01-30 09:38:37]

CQ bit was unchecked on CL. Ignoring.

[falken, 2014-01-30 11:03:38]

A revert of this CL has been created in
https://codereview.chromium.org/134133004/ by falken@chromium.org.

The reason for reverting is: Flaky crashes on full-screen-element-stack.html
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/26189

This test also crashed after the last attempt, but it looked like it was not due
to this patch since it kept crashing well after that patch was reverted. It
looks real now though..

[falken, 2014-01-31 13:34:38]

On 2014/01/30 11:03:38, falken wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/134133004/ by mailto:falken@chromium.org.
> 
> The reason for reverting is: Flaky crashes on full-screen-element-stack.html
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%2520Linux/builds/...
> 
> This test also crashed after the last attempt, but it looked like it was not
due
> to this patch since it kept crashing well after that patch was reverted. It
> looks real now though..

The crash is fixed by https://codereview.chromium.org/150273003/
I've run all layout tests on Debug and ASAN, and also browser_tests
--gtest_filter="*Fullscreen*:*FullScreen*" including
on Win, and it looks green to try again once the above fix lands.

[falken, 2014-02-03 05:48:07]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-02-03 05:48:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/falken@chromium.org/142653003/310001

[commit-bot: I haz the power, 2014-02-03 14:21:47]

Change committed as 166304

[commit-bot: I haz the power, 2014-02-03 14:21:49]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 14:21:50]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 14:21:56]

CQ bit was unchecked on CL. Ignoring.