Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1426513005: Modify local copy of fmt package to deep print structures with pointers. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
azani
CC:
jamesr, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Modify local copy of fmt package to deep print structures with pointers. BUG=#461 R=azani@chromium.org, azani Committed: https://chromium.googlesource.com/external/mojo/+/7db8018cabc90a596c527ebbc14eb7c8c77f3da6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/golang/README View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/golang/src/fmt/print.go View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rudominer
Alex ptal. jamesr@ is cc-d. https://codereview.chromium.org/1426513005/diff/1/third_party/golang/src/fmt/print.go File third_party/golang/src/fmt/print.go (left): https://codereview.chromium.org/1426513005/diff/1/third_party/golang/src/fmt/print.go#oldcode1001 third_party/golang/src/fmt/print.go:1001: if v != 0 ...
5 years, 1 month ago (2015-11-04 23:02:35 UTC) #3
azani
lgtm with a nit https://codereview.chromium.org/1426513005/diff/1/third_party/golang/src/fmt/print.go File third_party/golang/src/fmt/print.go (right): https://codereview.chromium.org/1426513005/diff/1/third_party/golang/src/fmt/print.go#newcode1003 third_party/golang/src/fmt/print.go:1003: //if v != 0 && ...
5 years, 1 month ago (2015-11-04 23:07:47 UTC) #4
rudominer
On 2015/11/04 23:07:47, azani wrote: > lgtm with a nit > > https://codereview.chromium.org/1426513005/diff/1/third_party/golang/src/fmt/print.go > File ...
5 years, 1 month ago (2015-11-04 23:09:33 UTC) #5
rudominer
5 years, 1 month ago (2015-11-04 23:09:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7db8018cabc90a596c527ebbc14eb7c8c77f3da6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698