[Quota][FileAPI] Add quota policy to FileSystemOperationContext

[Quota][FileAPI] Add quota policy to FileSystemOperationContext

BUG=220029
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196722

[tzik, 2013-04-26 06:19:44]

PTL.

This is needed to avoid race on getting quota policy in following patch.

[kinuko, 2013-04-26 06:44:21]

https://codereview.chromium.org/14265022/diff/32/webkit/fileapi/local_file_sy...
File webkit/fileapi/local_file_system_operation.cc (right):

https://codereview.chromium.org/14265022/diff/32/webkit/fileapi/local_file_sy...
webkit/fileapi/local_file_system_operation.cc:574:
operation_context()->set_quota_limit_type(quota::kQuotaLimitTypeUnlimited);
Looks like this is the primary change you want to make?

Can we check this in OpenFile() and bind the value to DidOpenFile() in
FileAPIMessageFilter, so that FS modules (which may not know anything about
quota policy) don't need to change DidOpenFile callback?

[tzik, 2013-04-26 06:55:11]

Moving Kinaba-san to CC, since I drop chromeos/ change.

Updated! PTAL.

https://codereview.chromium.org/14265022/diff/32/webkit/fileapi/local_file_sy...
File webkit/fileapi/local_file_system_operation.cc (right):

https://codereview.chromium.org/14265022/diff/32/webkit/fileapi/local_file_sy...
webkit/fileapi/local_file_system_operation.cc:574:
operation_context()->set_quota_limit_type(quota::kQuotaLimitTypeUnlimited);
On 2013/04/26 06:44:21, kinuko wrote:
> Looks like this is the primary change you want to make?
> 
> Can we check this in OpenFile() and bind the value to DidOpenFile() in
> FileAPIMessageFilter, so that FS modules (which may not know anything about
> quota policy) don't need to change DidOpenFile callback?

Done.

[kinuko, 2013-04-26 07:00:17]

Thanks for updating,

[kinuko, 2013-04-26 07:00:24]

https://codereview.chromium.org/14265022/diff/10018/webkit/fileapi/local_file...
File webkit/fileapi/local_file_system_operation.cc (right):

https://codereview.chromium.org/14265022/diff/10018/webkit/fileapi/local_file...
webkit/fileapi/local_file_system_operation.cc:583: }
Can we do this in SandboxMountPointProvider::CreateFileSystemOperation() and
make FSOC::set_quota_limit_type() private (if the value wouldn't/shouldn't be
changed after its creation)?

[tzik, 2013-04-26 07:17:59]

https://codereview.chromium.org/14265022/diff/10018/webkit/fileapi/local_file...
File webkit/fileapi/local_file_system_operation.cc (right):

https://codereview.chromium.org/14265022/diff/10018/webkit/fileapi/local_file...
webkit/fileapi/local_file_system_operation.cc:583: }
On 2013/04/26 07:00:25, kinuko wrote:
> Can we do this in SandboxMountPointProvider::CreateFileSystemOperation() and
> make FSOC::set_quota_limit_type() private (if the value wouldn't/shouldn't be
> changed after its creation)?

Done.

[kinuko, 2013-04-26 07:27:37]

lgtm with one nit

https://codereview.chromium.org/14265022/diff/5010/webkit/fileapi/sandbox_mou...
File webkit/fileapi/sandbox_mount_point_provider.cc (right):

https://codereview.chromium.org/14265022/diff/5010/webkit/fileapi/sandbox_mou...
webkit/fileapi/sandbox_mount_point_provider.cc:338: if (special_storage_policy_
&&
nit: I think you can also check this without passing special_storage_policy

context->quota_manager_proxy() &&
context->quota_manager_proxy()->IsStorageUnlimited(url.origin());

[tzik, 2013-04-26 07:36:26]

https://codereview.chromium.org/14265022/diff/5010/webkit/fileapi/sandbox_mou...
File webkit/fileapi/sandbox_mount_point_provider.cc (right):

https://codereview.chromium.org/14265022/diff/5010/webkit/fileapi/sandbox_mou...
webkit/fileapi/sandbox_mount_point_provider.cc:338: if (special_storage_policy_
&&
On 2013/04/26 07:27:37, kinuko wrote:
> nit: I think you can also check this without passing special_storage_policy
> 
> context->quota_manager_proxy() &&
> context->quota_manager_proxy()->IsStorageUnlimited(url.origin());

Done.

[commit-bot: I haz the power, 2013-04-26 07:36:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/14265022/3011

[commit-bot: I haz the power, 2013-04-26 09:38:56]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-04-26 09:56:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/14265022/8029

[commit-bot: I haz the power, 2013-04-26 13:51:21]

Change committed as 196722