Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: src/utils/SkBitmapHasher.h

Issue 14265010: Make SkSHA1 and SkM5 use common SkDigestHash result type (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: sync_to_r8826 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/utils/SkBitmapHasher.h
===================================================================
--- src/utils/SkBitmapHasher.h (revision 8826)
+++ src/utils/SkBitmapHasher.h (working copy)
@@ -11,11 +11,21 @@
#include "SkBitmap.h"
#include "SkBitmapTransformer.h"
+#include "SkHashDigest.h"
-// TODO(epoger): Soon, SkHashDigest will become a real class of its own,
-// and callers won't be able to assume it converts to/from a uint64_t.
-typedef uint64_t SkHashDigest;
+// TODO(epoger): Once we figure out which bitmap hash algorithm to use
+// long-term, pick one BITMAP_HASH_TYPE setting and delete the unused code.
+//
+// For now, disable this to keep the old uint64_t bitmap hash.
+#define BITMAP_HASH_TYPE_SkHashDigest
+// Set automatically using the above.
+#ifdef BITMAP_HASH_TYPE_SkHashDigest
+ #define BITMAP_HASH_TYPE SkHashDigest
+#else
+ #define BITMAP_HASH_TYPE uint64_t
+#endif
+
/**
* Static class that can generate an SkHashDigest from an SkBitmap.
*/
@@ -31,12 +41,12 @@
* intermediate SkBitmap and copy the pixels over to it... so in some
* cases, performance and memory usage can suffer.
*/
- static bool ComputeDigest(const SkBitmap& bitmap, SkHashDigest *result);
+ static bool ComputeDigest(const SkBitmap& bitmap, BITMAP_HASH_TYPE *result);
private:
static bool ComputeDigestInternal(const SkBitmap& bitmap,
const SkBitmapTransformer& transformer,
- SkHashDigest *result);
+ BITMAP_HASH_TYPE *result);
};
#endif
« no previous file with comments | « gm/tests/outputs/pipe-playback-failure/output-expected/json-summary.txt ('k') | src/utils/SkBitmapHasher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698