gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt - Issue 14265010: Make SkSHA1 and SkM5 use common SkDigestHash result type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gm/tests/outputs/compared-against-different-pixels-images/output-expected/json-summary.txt

Issue 14265010: Make SkSHA1 and SkM5 use common SkDigestHash result type (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: switch_to_MD5 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 "actual-results" : {	2 "actual-results" : {
	epoger 2013/04/18 17:45:48 Ready for renewed discussion at patchset 8. (Patc Ready for renewed discussion at patchset 8. (Patchsets 6/7/8 are all the same--"gcl upload" failed on patchsets 6 and 7, so I just kept retrying until it worked) epoger 2013/04/18 18:07:13 I should have made this clearer: please see the di Show quoted text On 2013/04/18 17:45:48, epoger wrote: > Ready for renewed discussion at patchset 8. I should have made this clearer: please see the diffs between patchset 5 and patchset 8. That set of changes just switched the hashing algorithm used "under the covers" in SkBitmapHasher.cpp. It it my view that the simplicity of switching algorithms justifies the existence of the SkHashDigest class, or perhaps some different wrapper around the hash results. If so, we can then examine the totality of this CL and look for cleanups...
3 "failed" : {	3 "failed" : {

4 "565/selftest1" : {	4 "565/selftest1" : {

5 "checksum" : 9512553915271796906	5 "checksum" : "320b5a7f0e7b69b35780e41f1b3f1937"
	epoger 2013/04/18 17:45:48 updated gm self-test results with MD5 digests inst updated gm self-test results with MD5 digests instead of CityHash
6 },	6 },

7 "8888/selftest1" : {	7 "8888/selftest1" : {

8 "checksum" : 14022967492765711532	8 "checksum" : "aa9f614e6cd7c81031f7c2aafad06fdc"

9 }	9 }

10 },	10 },

11 "failure-ignored" : null,	11 "failure-ignored" : null,

12 "no-comparison" : null,	12 "no-comparison" : null,

13 "succeeded" : null	13 "succeeded" : null

14 },	14 },

15 "expected-results" : {	15 "expected-results" : {

16 "565/selftest1" : {	16 "565/selftest1" : {

17 "checksums" : [ 11071285354315388429 ],	17 "checksums" : [ "73a2d3976df8027b6610ba431e89a7e0" ],

18 "ignore-failure" : false	18 "ignore-failure" : false

19 },	19 },

20 "8888/selftest1" : {	20 "8888/selftest1" : {

21 "checksums" : [ 16527650414256125612 ],	21 "checksums" : [ "d579b0446fcbacba94a2ef2dd48959f9" ],

22 "ignore-failure" : false	22 "ignore-failure" : false

23 }	23 }

24 }	24 }

25 }	25 }

OLD	NEW

« gm/gmmain.cpp ('K') | « gm/gmmain.cpp ('k') | gm/tests/outputs/compared-against-different-pixels-json/output-expected/json-summary.txt » ('j') | src/utils/SkBitmapHasher.cpp » ('J')