Fix R= line handling when there is no value and improve presubmit TAG line regex

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
@@ skipping 594 matching lines @@
         ]
     git_cl.main(['config'])
 
   def test_update_reviewers(self):
     data = [
       ('foo', [], 'foo'),
       ('foo', ['a@c'], 'foo\n\nR=a@c'),
       ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
       ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], 'foo\nTBR=a@c'),
       ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
+      ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
+      ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),

[iannucci, 2013/04/18 18:25:16]

Should there be tests to make sure that the newline-avoidance regex changes you
made WAI?

[M-A Ruel, 2013/04/19 16:58:42]

Added more checks to ensure no regression.

     ]
-    for orig, reviewers, expected in data:
+    expected = [i[2] for i in data]
+    actual = []
+    for orig, reviewers, _expected in data:
       obj = git_cl.ChangeDescription(orig)
       obj.update_reviewers(reviewers)
-      self.assertEqual(expected, obj.description)
+      actual.append(obj.description)
+    self.assertEqual(expected, actual)
 
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()