Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1426443008: Revert of Fix ClipMaskManager's SW-fallback logic (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix ClipMaskManager's SW-fallback logic (patchset #4 id:60001 of https://codereview.chromium.org/1421533007/ ) Reason for revert: Logic may be incorrect Original issue's description: > Fix ClipMaskManager's SW-fallback logic > > > 'useSWOnlyPath' was not correctly toggling between stencil and color draws so there was a mismatch with the behavior in createAlphaClipMask (i.e., we were inadvertently rendering some of the elements in a clip using SW but using stenciling for others - precisely what 'useSWOnlyPath' was intended to prevent). > > Committed: https://skia.googlesource.com/skia/+/5c3ea4cd3921e8904d4f201bcdedfd5b8a726542 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/24cdec1744892d499ce7ef59b81ea63b47193e24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -93 lines) Patch
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrPathRendererChain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 7 chunks +58 lines, -79 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Fix ClipMaskManager's SW-fallback logic
5 years, 1 month ago (2015-10-26 21:12:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426443008/1
5 years, 1 month ago (2015-10-26 21:12:21 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 21:12:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/24cdec1744892d499ce7ef59b81ea63b47193e24

Powered by Google App Engine
This is Rietveld 408576698