third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1426443003: Never paginate fixed-positioned objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1426443003: Never paginate fixed-positioned objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test for fixed positioned inside transform inside multicol. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 15fa2e07ca658736df4a6257d6befc6bdf59c775..59aacd4e46ad882f3e129ee73bc997c68c949b6c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -4404,7 +4404,10 @@ bool LayoutBox::hasUnsplittableScrollingOverflow() const

bool LayoutBox::isUnsplittableForPagination() const

{

- return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot());

+ return isReplaced()

+ || hasUnsplittableScrollingOverflow()

+ || (parent() && isWritingModeRoot())

+ || (isOutOfFlowPositioned() && style()->position() == FixedPosition);

}

LayoutUnit LayoutBox::lineHeight(bool /*firstLine*/, LineDirectionMode direction, LinePositionMode /*linePositionMode*/) const