Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1426443003: Never paginate fixed-positioned objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test for fixed positioned inside transform inside multicol. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 15fa2e07ca658736df4a6257d6befc6bdf59c775..59aacd4e46ad882f3e129ee73bc997c68c949b6c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4404,7 +4404,10 @@ bool LayoutBox::hasUnsplittableScrollingOverflow() const
bool LayoutBox::isUnsplittableForPagination() const
{
- return isReplaced() || hasUnsplittableScrollingOverflow() || (parent() && isWritingModeRoot());
+ return isReplaced()
+ || hasUnsplittableScrollingOverflow()
+ || (parent() && isWritingModeRoot())
+ || (isOutOfFlowPositioned() && style()->position() == FixedPosition);
}
LayoutUnit LayoutBox::lineHeight(bool /*firstLine*/, LineDirectionMode direction, LinePositionMode /*linePositionMode*/) const
« no previous file with comments | « third_party/WebKit/LayoutTests/printing/flexbox-with-overflow-in-bottom-aligned-fixedpos-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698