Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1426413002: Revert of Implement flag and source getters on RegExp.prototype. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rproto
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: browser_tests failure with --gtest_filter=ExternallyConnectableMessagingTest.EnablingAndDisabling Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} > > Committed: https://crrev.com/152163c1646b45f5fc5d31a4ec2eb55d7f4a2ffc > Cr-Commit-Position: refs/heads/master@{#31804} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Committed: https://crrev.com/ca49355abab75d60e7cc7fe366e1413bf49ca8f3 Cr-Commit-Position: refs/heads/master@{#31818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -224 lines) Patch
M include/v8.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M src/heap/heap.h View 6 chunks +5 lines, -2 lines 0 comments Download
M src/js/harmony-regexp.js View 3 chunks +1 line, -10 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -14 lines 0 comments Download
M src/js/prologue.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/regexp.js View 11 chunks +30 lines, -73 lines 0 comments Download
M src/js/string.js View 4 chunks +3 lines, -4 lines 0 comments Download
M src/js/symbol.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +29 lines, -8 lines 0 comments Download
D test/mjsunit/es6/regexp-flags.js View 1 chunk +0 lines, -49 lines 0 comments Download
M test/mjsunit/mirror-regexp.js View 3 chunks +32 lines, -21 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +14 lines, -20 lines 0 comments Download
M test/mjsunit/regress/regress-447561.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/test262/test262.status View 5 chunks +36 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Implement flag and source getters on RegExp.prototype.
5 years, 1 month ago (2015-11-05 09:07:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426413002/1
5 years, 1 month ago (2015-11-05 09:08:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 09:08:48 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 09:09:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca49355abab75d60e7cc7fe366e1413bf49ca8f3
Cr-Commit-Position: refs/heads/master@{#31818}

Powered by Google App Engine
This is Rietveld 408576698