Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1426403003: canvas: Remove darker composite operator (Closed)

Created:
5 years, 1 month ago by dshwang
Modified:
5 years, 1 month ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, Rik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

canvas: Remove darker composite operator At Nov 4, 2015, its usage is 0.0092% enough to be removed. https://www.chromestatus.com/metrics/feature/timeline/popularity/577 TEST=canvas/philip/tests/2d.composite.operation.darker.html BUG=425628 Committed: https://crrev.com/53f67af017d0c6554b82c3747eb35daacac49b35 Cr-Commit-Position: refs/heads/master@{#358092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/canvas/philip/tests/2d.composite.operation.darker-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dshwang
junov, could you review? sorry for delaying it. After landing, how should I edit https://www.chromestatus.com/features/5712397973061632 ...
5 years, 1 month ago (2015-11-05 09:26:42 UTC) #3
Justin Novosad
On 2015/11/05 09:26:42, dshwang wrote: > junov, could you review? sorry for delaying it. > ...
5 years, 1 month ago (2015-11-05 18:19:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426403003/1
5 years, 1 month ago (2015-11-05 18:24:28 UTC) #6
Justin Novosad
On 2015/11/05 18:19:09, Justin Novosad wrote: > On 2015/11/05 09:26:42, dshwang wrote: > > junov, ...
5 years, 1 month ago (2015-11-05 18:25:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 18:29:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53f67af017d0c6554b82c3747eb35daacac49b35 Cr-Commit-Position: refs/heads/master@{#358092}
5 years, 1 month ago (2015-11-05 18:30:42 UTC) #9
dshwang
5 years, 1 month ago (2015-11-05 18:34:33 UTC) #10
Message was sent while issue was closed.
On 2015/11/05 18:25:00, Justin Novosad wrote:
> On 2015/11/05 18:19:09, Justin Novosad wrote:
> > On 2015/11/05 09:26:42, dshwang wrote:
> > > junov, could you review? sorry for delaying it.
> > > After landing, how should I edit
> > > https://www.chromestatus.com/features/5712397973061632 ?
> > > This feature was deprecated in M42 already in the dashboard.
> > 
> > lgtm
> > 
> > dashboard should say removed in Chrome 48
> 
> I updated the dashboard.

Thanks Justin a lot!! I checked :)

Powered by Google App Engine
This is Rietveld 408576698