Create errors (especially cancellation errors) internally to WebCore, rather

Source/WebCore/platform/network/ResourceError.cpp

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "ResourceError.h"
 
 namespace WebCore {
 
 const char* const errorDomainWebKitInternal = "WebKitInternal";
+const char* const errorDomainNet = "net";
+
+const int cancelledErrorCode = -3;

[Nate Chapin, 2013/04/15 17:44:32]

This is the only thing I don't like about this change.

Because WebCore doesn't have access to src/net/base/net_errors.h, it doesn't
know the chromium net error codes. So I don't see how to make this otherwise
reasonable change without duplicating the cancellation error code definition.

+
+const int policyChangeError = -10000;
+
+ResourceError ResourceError::createCancelledError(const String& failingURL)
+{
+    ResourceError error(errorDomainNet, cancelledErrorCode, failingURL, String());
+    error.setIsCancellation(true);
+    return error;
+}
+
+ResourceError ResourceError::createPolicyChangeError(const String& failingURL)
+{
+    return ResourceError(errorDomainWebKitInternal, policyChangeError, failingURL, String());
+}
 
 ResourceError ResourceError::copy() const
 {
     ResourceError errorCopy;
     errorCopy.m_domain = m_domain.isolatedCopy();
     errorCopy.m_errorCode = m_errorCode;
     errorCopy.m_failingURL = m_failingURL.isolatedCopy();
     errorCopy.m_localizedDescription = m_localizedDescription.isolatedCopy();
     errorCopy.m_isNull = m_isNull;
     errorCopy.m_isCancellation = m_isCancellation;
@@ skipping 24 matching lines @@
     if (a.isCancellation() != b.isCancellation())
         return false;
 
     if (a.isTimeout() != b.isTimeout())
         return false;
 
     return true;
 }
 
 } // namespace WebCore