Issue 14264009: Merge Windows, Mac OS X and Cygwin sampler implementations with the rest ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14264009: Merge Windows, Mac OS X and Cygwin sampler implementations with the rest ones (Closed)

Created:
7 years, 8 months ago by yurys

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne, loislo, alph, Jakob Kummerow

CC:
chromium-reviews

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

This change is a continuation of the refactoring started in r14265. Renamed SignalSender to SamplerThread to match platforms that don't support signal sending. Cygwin and Windows implementations are almost identical. Mac OS X uses different API to suspend thread but apart from that it is very similar to Windows implenenation. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14272

Patch Set 1 #

Patch Set 2 : Windows supported #

Patch Set 3 : Added Cygwind support #

Patch Set 4 : Android build fix #

Patch Set 5 : Fix Android build #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -627 lines)			Patch
M	src/isolate.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	src/platform-cygwin.cc	View	1 2	2 chunks	+0 lines, -194 lines	0 comments	Download
M	src/platform-macos.cc	View		1 chunk	+0 lines, -194 lines	0 comments	Download
M	src/platform-win32.cc	View	1	2 chunks	+0 lines, -192 lines	0 comments	Download
M	src/sampler.cc	View	1 2 3 4	13 chunks	+258 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 8 months ago (2013-04-16 08:54:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r14272 (presubmit successful).

Expand Messages | Collapse Messages