Re-land: NativeTextfieldViews: Show the drop cursor when dragging text

ui/views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 245 matching lines @@
 bool NativeTextfieldViews::CanDrop(const OSExchangeData& data) {
   int formats;
   std::set<OSExchangeData::CustomFormat> custom_formats;
   GetDropFormats(&formats, &custom_formats);
   return textfield_->enabled() && !textfield_->read_only() &&
       data.HasAnyFormat(formats, custom_formats);
 }
 
 int NativeTextfieldViews::OnDragUpdated(const ui::DropTargetEvent& event) {
   DCHECK(CanDrop(event.data()));
-  bool in_selection = GetRenderText()->IsPointInSelection(event.location());
+
+  const gfx::Point& location = event.location();
+  bool in_selection = GetRenderText()->IsPointInSelection(location);
   is_drop_cursor_visible_ = !in_selection;
+  if (is_drop_cursor_visible_)
+    drop_cursor_position_ = GetRenderText()->FindCursorPosition(location);

[msw, 2013/04/15 17:14:04]

You can optionally avoid calling both FindCursorPosition and IsPointInSelection
(which also calls FindCursorPosition), but you'd probably need to expose
RangeContainsCaret (protected->public). This is really optional for this CL,
I'll take another look if you choose to do it.

[ckocagil, 2013/04/15 20:41:15]

Done.

   // TODO(msw): Pan over text when the user drags to the visible text edge.
   OnCaretBoundsChanged();
   SchedulePaint();
 
   if (initiating_drag_) {
     if (in_selection)
       return ui::DragDropTypes::DRAG_NONE;
     return event.IsControlDown() ? ui::DragDropTypes::DRAG_COPY :
                                    ui::DragDropTypes::DRAG_MOVE;
   }
   return ui::DragDropTypes::DRAG_COPY | ui::DragDropTypes::DRAG_MOVE;
 }
 
+void NativeTextfieldViews::OnDragExited() {
+  is_drop_cursor_visible_ = false;
+  SchedulePaint();
+}
+
 int NativeTextfieldViews::OnPerformDrop(const ui::DropTargetEvent& event) {
   DCHECK(CanDrop(event.data()));
 
   TextfieldController* controller = textfield_->GetController();
   if (controller) {
       int drag_operation = controller->OnDrop(event.data());
       if (drag_operation != ui::DragDropTypes::DRAG_NONE)
         return drag_operation;
   }
 
@@ skipping 783 matching lines @@
 
 void NativeTextfieldViews::RepaintCursor() {
   gfx::Rect r(GetCaretBounds());
   r.Inset(-1, -1, -1, -1);
   SchedulePaintInRect(r);
 }
 
 void NativeTextfieldViews::PaintTextAndCursor(gfx::Canvas* canvas) {
   TRACE_EVENT0("views", "NativeTextfieldViews::PaintTextAndCursor");
   canvas->Save();
-  GetRenderText()->set_cursor_visible(is_drop_cursor_visible_ ||
-      (is_cursor_visible_ && !model_->HasSelection()));
+  GetRenderText()->set_cursor_visible(!is_drop_cursor_visible_ &&
+      is_cursor_visible_ && !model_->HasSelection());
   // Draw the text, cursor, and selection.
   GetRenderText()->Draw(canvas);
 
+  // Draw the detached drop cursor that marks where the text will be dropped.
+  if (is_drop_cursor_visible_)
+    GetRenderText()->DrawCursor(canvas, drop_cursor_position_);
+
   // Draw placeholder text if needed.
   if (model_->GetText().empty() &&
       !textfield_->placeholder_text().empty()) {
     canvas->DrawStringInt(
         textfield_->placeholder_text(),
         GetRenderText()->GetFont(),
         textfield_->placeholder_text_color(),
         GetRenderText()->display_rect());
   }
   canvas->Restore();
@@ skipping 314 matching lines @@
 
 void NativeTextfieldViews::PlatformGestureEventHandling(
     const ui::GestureEvent* event) {
 #if defined(OS_WIN) && defined(USE_AURA)
   if (event->type() == ui::ET_GESTURE_TAP_DOWN && !textfield_->read_only())
     base::win::DisplayVirtualKeyboard();
 #endif
 }
 
 }  // namespace views