Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1426353002: Fix glob patterns to work on Windows (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
The first CL broke the Windows bots. After getting help from Natalie, I think this ...
5 years, 1 month ago (2015-11-03 22:50:48 UTC) #2
scheglov
lgtm
5 years, 1 month ago (2015-11-03 23:11:53 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-11-03 23:35:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aaaf7c2de8708e534acaeee60b692ba2bb08e4d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698