Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 14263024: Logging API in chromedriver2. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session_commands.cc
===================================================================
--- chrome/test/chromedriver/session_commands.cc (revision 194587)
+++ chrome/test/chromedriver/session_commands.cc (working copy)
@@ -17,6 +17,7 @@
#include "chrome/test/chromedriver/basic_types.h"
#include "chrome/test/chromedriver/chrome/automation_extension.h"
#include "chrome/test/chromedriver/chrome/chrome.h"
+#include "chrome/test/chromedriver/chrome/devtools_event_logger.h"
#include "chrome/test/chromedriver/chrome/geoposition.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/chrome/web_view.h"
@@ -472,3 +473,37 @@
return extension->MaximizeWindow();
}
+
+Status ExecuteGetAvailableLogTypes(
+ Session* session,
+ const base::DictionaryValue& params,
+ scoped_ptr<base::Value>* value) {
+ scoped_ptr<ListValue> types(new base::ListValue());
+ for (ScopedVector<DevToolsEventLogger>::const_iterator logger =
+ session->devtools_event_loggers.begin();
+ logger != session->devtools_event_loggers.end(); ++logger) {
+ types->AppendString((*logger)->GetLogType());
+ }
+ value->reset(types.release());
+ return Status(kOk);
+}
+
+Status ExecuteGetLog(
+ Session* session,
+ const base::DictionaryValue& params,
+ scoped_ptr<base::Value>* value) {
+ std::string log_type;
+ if (!params.GetString("type", &log_type)) {
+ return Status(kUnknownError, "missing or invalid 'type'");
+ }
+ for (ScopedVector<DevToolsEventLogger>::const_iterator logger =
+ session->devtools_event_loggers.begin();
+ logger != session->devtools_event_loggers.end(); ++logger) {
+ if (log_type == (*logger)->GetLogType()) {
+ scoped_ptr<ListValue> log_entries = (*logger)->GetAndClearLogEntries();
+ value->reset(log_entries.release());
+ return Status(kOk);
+ }
+ }
+ return Status(kUnknownError, "log type '" + log_type + "' not found");
+}
« chrome/test/chromedriver/logging.cc ('K') | « chrome/test/chromedriver/session_commands.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698