Issue 14263015: Fix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14263015: Fix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer. (Closed)

Created:
7 years, 8 months ago by Justin Novosad

Modified:
7 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix crash with SkDeferredCanvas+SkSurface integration with in order draw buffer. The fImmediateDevice member of DeferredDevice (SkDeferredCanvas.cpp) was becoming invalid after a fork of the backingstore in SkSurface_Gpu cause the device to be substituted. New unit test code was to exercise SkSurface copy on write with draws that are deferred in GrInOrderDrawBuffer. The bad pointer was causing the test to crash. TEST=skia unit test DeferredCanvas, subtest TestDeferredCanvasSurface Committed: https://code.google.com/p/skia/source/detail?r=8686

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -17 lines)			Patch
	M	src/utils/SkDeferredCanvas.cpp	View		9 chunks	+10 lines, -13 lines	0 comments	Download
	M	tests/DeferredCanvasTest.cpp	View	1	1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages