Refactor our SimpleIndex file format and serialization to use Pickle instead of the previously bugg…

net/disk_cache/simple/simple_synchronous_entry.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/simple/simple_synchronous_entry.h"
 
 #include <algorithm>
 #include <cstring>
 #include <limits>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/hash.h"
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop_proxy.h"
 #include "base/sha1.h"
 #include "base/stringprintf.h"
 #include "base/task_runner.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
+#include "net/disk_cache/simple/simple_index_util.h"

[gavinp, 2013/04/15 15:40:54]

Really?

[felipeg, 2013/04/15 15:56:09]

Yes because of using GetEntryHashKeyAsHexString()

 
 using base::ClosePlatformFile;
 using base::FilePath;
 using base::GetPlatformFileInfo;
 using base::PlatformFileError;
 using base::PlatformFileInfo;
 using base::PLATFORM_FILE_CREATE;
 using base::PLATFORM_FILE_OK;
 using base::PLATFORM_FILE_OPEN;
 using base::PLATFORM_FILE_READ;
@@ skipping 271 matching lines @@
       // TODO(gavinp): Clean up created files.
       DLOG(WARNING) << "Could not write keys to new cache entry.";
       return false;
     }
   }
   initialized_ = true;
   return true;
 }
 
 }  // namespace disk_cache