Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1426293005: //breakpad:symuploader should only compile with the host toolchain. (Closed)

Created:
5 years, 1 month ago by slan
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//breakpad:symuploader should only compile with the host toolchain. BUG= Committed: https://crrev.com/e6031b84b20deca377949e4f2057770e81e0eecc Cr-Commit-Position: refs/heads/master@{#357837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
slan
5 years, 1 month ago (2015-11-04 16:02:43 UTC) #2
slan
+pkotwicz@
5 years, 1 month ago (2015-11-04 16:12:50 UTC) #4
pkotwicz
LGTM For my own education, in which cases are host_toolchain & default_toolchain different on non-mobile ...
5 years, 1 month ago (2015-11-04 16:22:53 UTC) #5
slan
On 2015/11/04 16:22:53, pkotwicz wrote: > LGTM > > For my own education, in which ...
5 years, 1 month ago (2015-11-04 16:28:13 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426293005/1
5 years, 1 month ago (2015-11-04 16:29:14 UTC) #8
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-04 16:51:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426293005/1
5 years, 1 month ago (2015-11-04 16:58:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 17:19:39 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 17:20:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6031b84b20deca377949e4f2057770e81e0eecc
Cr-Commit-Position: refs/heads/master@{#357837}

Powered by Google App Engine
This is Rietveld 408576698