lib/runtime/dart/core.js - Issue 1426243002: fix #379, escape of $ in template strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/core.js

Issue 1426243002: fix #379, escape of $ in template strings (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/core.js

diff --git a/lib/runtime/dart/core.js b/lib/runtime/dart/core.js

index d46c1429827c4baf33c4b7bfd1e9db8fb196df15..b1ac1a7d1e3a2364298dab0fae4b19639ae1b5c1 100644

--- a/lib/runtime/dart/core.js

+++ b/lib/runtime/dart/core.js

@@ -1184,7 +1184,7 @@ dart_library.library('dart/core', null, /* Imports */[

[_getKey]() {

let key = dart.as(_js_helper.Primitives.getProperty(this, Expando$()._KEY_PROPERTY_NAME), String);

if (key == null) {

- key = `expando$key$${(() => {

+ key = `expando\$key\$${(() => {

let x = Expando$()._keyCount;

Expando$()._keyCount = dart.notNull(x) + 1;

return x;