Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1426243002: fix #379, escape of $ in template strings (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly
Modified:
5 years, 1 month ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M lib/runtime/dart/_internal.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/core.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/js/builder.dart View 1 1 chunk +16 lines, -9 lines 1 comment Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/misc.js View 2 chunks +3 lines, -1 line 0 comments Download
M test/codegen/misc.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1426243002/diff/20001/lib/src/js/builder.dart File lib/src/js/builder.dart (right): https://codereview.chromium.org/1426243002/diff/20001/lib/src/js/builder.dart#newcode312 lib/src/js/builder.dart:312: var re = new RegExp('[\n\r$quoteReplace\b\f\t\v\u2028\u2029]'); not sure why this ...
5 years, 1 month ago (2015-11-02 18:26:33 UTC) #3
vsm
lgtm
5 years, 1 month ago (2015-11-02 18:31:54 UTC) #4
Jennifer Messerly
5 years, 1 month ago (2015-11-02 18:32:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
914b56640af60226553a7a300e926fd4b1afb64b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698